Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(engine-api): Shanghai support #1445

Merged
merged 14 commits into from
Feb 21, 2023
Merged

feat(engine-api): Shanghai support #1445

merged 14 commits into from
Feb 21, 2023

Conversation

rkrasiuk
Copy link
Member

closes #1297

@rkrasiuk rkrasiuk added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Feb 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023 •
edited
Loading

Codecov Report

Merging #1445 (09b44f5) into main (058349e) will increase coverage by 0.01%.
The diff coverage is 85.08%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1445      +/-   ##
==========================================
+ Coverage   76.10%   76.11%   +0.01%     
==========================================
  Files         358      358              
  Lines       42245    42355     +110     
==========================================
+ Hits        32149    32238      +89     
- Misses      10096    10117      +21
Flag Coverage Δ
integration-tests 21.94% <0.00%> (-0.08%) ⬇️
unit-tests 70.60% <85.08%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/rpc/rpc-api/src/engine.rs 0.00% <ø> (ø)
crates/rpc/rpc-engine-api/src/lib.rs 100.00% <ø> (ø)
crates/rpc/rpc-engine-api/src/message.rs 0.00% <0.00%> (ø)
crates/rpc/rpc/src/engine/mod.rs 0.00% <0.00%> (ø)
crates/storage/provider/src/traits/header.rs 88.88% <ø> (ø)
crates/rpc/rpc-engine-api/src/engine_api.rs 93.80% <95.19%> (-1.92%) ⬇️
crates/rpc/rpc-engine-api/src/error.rs 100.00% <100.00%> (ø)
crates/rpc/rpc-types/src/eth/engine.rs 89.15% <100.00%> (+7.01%) ⬆️
crates/net/discv4/src/proto.rs 89.66% <0.00%> (-3.13%) ⬇️
crates/stages/src/stages/hashing_storage.rs 95.65% <0.00%> (-0.55%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gakonst
gakonst reviewed Feb 18, 2023
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start!

crates/rpc/rpc/src/engine/mod.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-engine-api/src/engine_api.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-engine-api/src/engine_api.rs Show resolved Hide resolved
crates/rpc/rpc-engine-api/src/engine_api.rs Outdated Show resolved Hide resolved
@rkrasiuk rkrasiuk marked this pull request as ready for review February 20, 2023 16:34
@rkrasiuk rkrasiuk mentioned this pull request Feb 20, 2023
Merged
mattsse
mattsse requested changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nits

crates/rpc/rpc-engine-api/src/message.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-types/src/eth/engine.rs Outdated Show resolved Hide resolved
mattsse
mattsse approved these changes Feb 20, 2023
View reviewed changes
crates/rpc/rpc-types/src/eth/engine.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-types/src/eth/engine.rs Outdated Show resolved Hide resolved
@rkrasiuk @mattsse
Apply suggestions from code review
142ee1c 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
gakonst
gakonst approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full send - nice work

crates/rpc/rpc-types/src/eth/engine.rs
Comment on lines +199 to +201
#[test]
fn payload_body_roundtrip() {
for block in random_block_range(0..100, H256::default(), 0..2) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @joshieDo re: deduping these

@gakonst gakonst merged commit 03832d6 into main Feb 21, 2023
@gakonst gakonst deleted the rkrasiuk/shanghai-engine-api branch February 21, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst gakonst approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Engine API Changes for Shanghai
4 participants
@rkrasiuk @codecov-commenter @gakonst @mattsse