Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jspdf install fails due to github branch referenced as dependency #2559

Closed
RHellmann opened this issue Aug 13, 2019 · 9 comments
Closed

jspdf install fails due to github branch referenced as dependency #2559

RHellmann opened this issue Aug 13, 2019 · 9 comments

Comments

@RHellmann
Copy link

RHellmann commented Aug 13, 2019

The dependency file-saver is currently added as a direct reference to a Github branch. This causes errors during install in some cases and during CI/CD.

when installed, package.json in node-modules shows

"file-saver": "github:eligrey/FileSaver.js#1.3.8",

instead of

"file-saver": "2.0.1",

@RHellmann
Copy link
Author

Update: this is a known bug in file-saver 2.0.1 - updating to 2.0.2 should fix this.

eligrey/FileSaver.js#526

@RHellmann
Copy link
Author

created a pull request #2560

@almercier
Copy link

This is already done in master with #2333, originally reported here #2208
We are all waiting on a release of v1.5.4 since then but yet still nothing.

@caneta
Copy link

caneta commented Aug 28, 2019

Same problem here, apparently only on Windows environments...

@isipisi89
Copy link

Same problem here.
We are all waiting on a release of v1.5.4
Could you pleas let us know what time the release of 1.5.4 will be at?

@ShyamRaj
Copy link

Same issue in installing v1.5.3

@tombreit
Copy link

We're experience this issue in a docker deployment (image python:3.7-slim-buster) and would be glad using an upcoming version (1.5.4?) in which this issue is fixed (like @almercier already mentioned).

@github-actions
Copy link

github-actions bot commented Jul 8, 2020

This issue is stale because it has been open 90 days with no activity. It will be closed soon. Please comment/reopen if this issue is still relevant.

@HoffmannThomas
Copy link

Since we see a lot of issues mentioning this problem (docker image without git, cooperate firewall, etc.) a bugfix release (1.5.4?) would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants