-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest version not on NPM/ Types question #3013
Comments
Also, I discovered then when using the latest version where enums ImageCompression and ColorSpace exported, it leads to an 'ImageCompression.FAST is undefined' error, because jspdf does not export them. |
Thanks for the PR :) Regarding the ImageCompression.FAST is undefined: I noticed this, as well. Either we should convert the enum types to string union types or export the respective objects in JavaScript. I think the string union type is the better alternative, do you agree? Could you maybe also create a PR for this? |
This issue is stale because it has been open 90 days with no activity. It will be closed soon. Please comment/reopen if this issue is still relevant. |
Hi I want to reopen this issue. I'm having the same problem. |
I ran across an issue with the types and found the #2894 which was fixed, but the version including the PR #2933 does not seem to be included in the latest published version on NPM.
If you can replicate this, can you suggest when it will become available?
My main problem at the moment is being unable to use it without custom tweaks because of ImageCompression and other options not be exported correctly.
Another problem is that the current types do not include doc.internal.events.subscribe and doc.internal.events.unsubscribe.
If I make an PR, will it be possible to have it merged and published on NPM?
Thank you.
UPD: I created a PR: #3014
The text was updated successfully, but these errors were encountered: