diff --git a/utils/debug.c b/utils/debug.c index bbf526fe2..ae68c5a19 100644 --- a/utils/debug.c +++ b/utils/debug.c @@ -383,8 +383,8 @@ void print_time_unit(uint64_t delta_nsec) void print_diff_percent(uint64_t base_nsec, uint64_t pair_nsec) { - double percent = 999.99; - const char *sc = get_color(COLOR_CODE_NORMAL); + double percent; + const char *sc; const char *ec = get_color(COLOR_CODE_RESET); if (base_nsec == 0) { diff --git a/utils/kernel.c b/utils/kernel.c index fabe50fd7..5446b86a4 100644 --- a/utils/kernel.c +++ b/utils/kernel.c @@ -43,7 +43,6 @@ struct kfilter { static int set_filter_file(const char *filter_file, struct list_head *filters) { struct kfilter *pos, *tmp; - int ret = -1; int fd; fd = open_tracing_file(filter_file, true); @@ -64,10 +63,9 @@ static int set_filter_file(const char *filter_file, struct list_head *filters) if (write(fd, " ", 1) != 1) pr_dbg2("writing filter file failed, but ignoring...\n"); } - ret = 0; close(fd); - return ret; + return 0; } static int set_tracing_filter(struct uftrace_kernel_writer *kernel) diff --git a/utils/perf.c b/utils/perf.c index b1a0197fc..a5c56c7bc 100644 --- a/utils/perf.c +++ b/utils/perf.c @@ -227,7 +227,6 @@ void record_perf_data(struct uftrace_perf_writer *perf, int cpu, int sock) buf = &data[start & mask]; size = end - start; - start += size; if (sock > 0) send_trace_perf_data(sock, cpu, buf, size);