Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add array tracing from PR #120. #165

Merged
merged 1 commit into from
May 18, 2015
Merged

Add array tracing from PR #120. #165

merged 1 commit into from
May 18, 2015

Conversation

albertnetymk
Copy link
Contributor

Variables with parametric type are not properly traced, which should be taken care of in another PR.

@albertnetymk
Copy link
Contributor Author

streams.enc is breaking the build. In fact, streams are not supported, for it shares unfulfilled futures.

@EliasC
Copy link
Contributor

EliasC commented May 12, 2015

@albertnetymk Could you try to make the stream non-polymorphic? I.e. change the streaming method interleave to

  stream interleave(s1 : Stream int, s2 : Stream int) : int{
    while ((not eos s1) and (not eos s2)) {
      yield get s1;
      yield get s2;
      s1 = getNext s1;
      s2 = getNext s2;
    }
  }

@albertnetymk
Copy link
Contributor Author

@EliasC Why does it make any difference? The reason why stream fails is not because it's using polymorphic type. Instead, it's because it's sharing futures underneath.

@EliasC
Copy link
Contributor

EliasC commented May 12, 2015

@albertnetymk It's one less error source to worry about. This PR changes tracing, something that we know doesn't work well for polymorphic values, and this test has passed before, so it's worth a try.

@albertnetymk albertnetymk mentioned this pull request May 12, 2015
@albertnetymk
Copy link
Contributor Author

@EliasC Sure. However, the origial streams.enc uses int for polymorphic type variable anyway, so nothing to trace. It was working before by accident, I believe. The backend has never been correctly implemented to support streams, if using pony_allloc. The same argument goes for largestream.enc.

@EliasC
Copy link
Contributor

EliasC commented May 12, 2015

@albertnetymk Then maybe we should consider removing streams.enc from the Jenkins build as well? No point in being alerted that something we know is broken is broken. What is your opinion @kikofernandez?

@albertnetymk
Copy link
Contributor Author

Rebaesd onto 871a17b. Build fails for async_force_gc, async_foreach, and streams, which is expected.

kikofernandez pushed a commit that referenced this pull request May 18, 2015
@kikofernandez kikofernandez merged commit 6b0e734 into parapluu:master May 18, 2015
@kikofernandez kikofernandez deleted the trace-array branch May 18, 2015 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants