Use new argument field names in dispatch function. #74
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm on it |
The old argument names are `x`,`y`,`bar` -- corresponding to the encore level names. The new names are `f1`..`fN`. This commit implements the convention in the dispatch function generation. To make the produced argument structs more pleasant to read, we also added an 'Annotated' constructor to the 'CCode' type so the structs can document the fields.
|
This strikes me as a bad idea, since reading the code you've written, it seems (at least in some places) that you already know the encore level names of the fields, and in order to do the mapping properly elsewhere, I again need to know the encore level names of fields. But perhaps I'm missing something. |
|
@supercooldave I agree. Apparently keeping the good names makes other code too complicated. I have a strong feeling @EliasC will fix this in the future. |
|
@supercooldave We use the names in the places where we have them. We don't have them in expression translation at the moment. Adding them there would be possible in the future but is not an urgent priority. |
TobiasWrigstad
added a commit
that referenced
this pull request
Feb 5, 2015
Use new argument field names in dispatch function.
|
+1 on everything :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old argument names are
x,y,bar-- corresponding to theencore level names. The new names are
f1..fN. This commitimplements the convention in the dispatch function generation.
To make the produced argument structs more pleasant to read, we also
added an
Annotatedconstructor to theCCodetype so the structscan document the fields.