Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check key validity on public API #12

Open
fia0 opened this issue Nov 10, 2022 · 1 comment
Open

Check key validity on public API #12

fia0 opened this issue Nov 10, 2022 · 1 comment
Labels
improvement

Comments

@fia0
Copy link

fia0 commented Nov 10, 2022

Extracted from Till's notes:

Empty keys will panic and keys with a size of many KB should probably be disallowed too.

Adding error types is necessary for empty keys. The upper bound on key size could be set but concerning the actual number, we need to find some reasonable measure to determine this.
@fia0
Copy link
Author

fia0 commented Dec 5, 2022

Same goes for keys containing a null byte.

This was referenced Dec 6, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fia0