Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paysWithFeeOrigin? optional input seems to be broken #419

Closed
IkerAlus opened this issue Jul 2, 2024 · 0 comments · Fixed by #420
Closed

paysWithFeeOrigin? optional input seems to be broken #419

IkerAlus opened this issue Jul 2, 2024 · 0 comments · Fixed by #420
Assignees
Labels
Bug Something isn't working P1 - High High Priority

Comments

@IkerAlus
Copy link
Contributor

IkerAlus commented Jul 2, 2024

If I construct a payload with the paysWithFeeOrigin? optional input as an integer (Asset Hub as origin), the API creates it with a zero asset ID is XCM location. The expected behaviour should be to error out saying the input is not a valid asset ID.

  • Steps to reproduce: Run the assetHubToMoonriverPaysWithFeeOrigin.ts example.

Also, if I change the ID to a different integer (an integer not registered as a sufficient asset), the API returns the error "InvalidAsset: asset with assetId {assetID} is not a sufficient asset to pay for fees" which is misleading. The error should point to the fact that there is no liquidity pool of the given asset in the asset conversion pallet or simply say that the input is not a valid asset ID. Asset sufficiency is not relevant anymore in Kusama and Polkadot Asset Hubs to pay fees.

Extra: paysWithFeeOrigin? optional input doesn't allow to pass asset symbols like USDT, it would be nice to add this enhancement.

@IkerAlus IkerAlus added Bug Something isn't working P1 - High High Priority labels Jul 2, 2024
@marshacb marshacb self-assigned this Jul 2, 2024
@marshacb marshacb moved this to Done in Asset Transfer API Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working P1 - High High Priority
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants