-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing of docker STDOUT #1526
Conversation
I think it would be great to have a CI test, which could catch issues like this. |
The problem is that we need to have a nested docker environment. Idk if it's possible to run docker container inside another container. |
I do not see any docker image used for CI, it seems that we are building this directly on the runner |
Sure, I'll do it in the follow up PR then |
@SkymanOne Please create a GitHub issue for it and assign it to yourself. |
Summary
Closes #1455
ink
orpallet-contracts
?It was previously common to see the following error at the end of a verifiable build, even when the build was successful:
The previous implementation expected the
BuildResult
to be sent in a stream as a whole chunk of bytes. However, there can be cases when the data is sent in multiple chunks, which results in incorrect parsing.We simply collect the byte chunks and then attempt to decode them together.
Checklist before requesting a review
CHANGELOG.md