Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check is broken on frame-metadata #50

Closed
TriplEight opened this issue Aug 2, 2021 · 4 comments
Closed

Check is broken on frame-metadata #50

TriplEight opened this issue Aug 2, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@TriplEight
Copy link

TriplEight commented Aug 2, 2021

Ref CI job, the error is

error[E0432]: unresolved imports `frame_metadata::DecodeDifferent`, `frame_metadata::DecodeDifferentArray`, `frame_metadata::DefaultByte`, `frame_metadata::DefaultByteGetter`, `frame_metadata::ErrorMetadata`, `frame_metadata::FunctionArgumentMetadata`, `frame_metadata::FunctionMetadata`, `frame_metadata::ModuleConstantMetadata`, `frame_metadata::ModuleErrorMetadata`

Now it's merged into master and that means that on the next version bump we will release the broken packages.

I'll take care of removing the publishing job until the issue is fixed.

@gnunicorn
Copy link
Contributor

gnunicorn commented Aug 2, 2021

I think the problem is that we have conflicting frame_metadata while the crate is being moved out. It has already been published as an rc1, but I dunno the current status about removing the conflict from the substrate repo. tagged @ascjones , who is working on this.

@ascjones
Copy link

ascjones commented Aug 2, 2021

Exactly, hence I have since yanked the the new version of frame_metadata for now. Once my PR is merged then frame_metadata will have been removed from substrate so I assume that this will resolve itself.

Apologies for this, I wasn't aware of how this would cause problems with the unleash check.

@gilescope
Copy link

gilescope commented Oct 4, 2021

@ascjones your PR is now merged, so is maybe this check not broken any more?

@ascjones
Copy link

ascjones commented Oct 4, 2021

It is. So just would need a new PR to restore the check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants