This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
lookahead collator: read allowed ancestry len from relay clien #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slumber
added
B0-silent
slumber
commented
Aug 24, 2023
|
|
||
| read_result | ||
| .map(|config| config.async_backing_params.allowed_ancestry_len as usize) | ||
| .unwrap_or(0) |
There was a problem hiding this comment.
Default value was 2, but any error in this path indicates huge problem related to the node or relay chain.
So 0 is somewhat conservative, although makes little to no difference.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2706
Implements 2nd approach from #2706 (comment)