Add Setter for XCMP QueueConfigData

[apopiak]

cumulus/pallets/xcmp-queue/src/lib.rs

Lines 166 to 168 in 8cc008b

	/// The configuration which controls the dynamics of the outbound queue.
	#[pallet::storage]
	pub(super) type QueueConfig<T: Config> = StorageValue<_, QueueConfigData, ValueQuery>;

QueueConfigData is read but there is no way to write it (in contrast to e.g. Polkadot's HostConfiguration).
Would be good to add a setter (that is only available to root).

[Doordashcon]

Hi @apopiak so we need a separate function exclusively for inserting data(QueueConfigData) into the storage item QueueConfig?

[apopiak]

@Doordashcon Yes, we want an extrinsic that allows setting it so governance can update the values if necessary.

[Doordashcon]

Nice! The root/origin would be type QueueConfigDataOrigin: EnsureOrigin<Self::Origin>; enabling implementors assign governance?

[apopiak]

yeah, sure, we could introduce ConfigUpdateOrigin or UpdateOrigin or sth.
Though, just requiring root would allow us to avoid downstream changes.
Either works, though.

[Doordashcon]

I'm on it!

[Doordashcon]

@apopiak there is no benchmarking.rs file, how do I assign weight to the update_config extrinsic?

[KiChjang]

@Doordashcon Since it involves a storage write, I think using T::DbWeight::get().writes(1) is good enough.

[Doordashcon]

@Doordashcon Since it involves a storage write, I think using T::DbWeight::get().writes(1) is good enough.

won't I need to kill existing storage if any before the update?

[KiChjang]

No? You're overwriting the existing QueueConfigData with a new one.

[KiChjang]

Fixed in #931, weights for the pallet is tracked in #961.