Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Change account import workflow #137

Closed
ltfschoen opened this issue Jul 5, 2018 · 6 comments
Closed

Change account import workflow #137

ltfschoen opened this issue Jul 5, 2018 · 6 comments

Comments

@ltfschoen
Copy link
Contributor

On the "Accounts" page, if I click "+" and then click "Import Account", and then enter secret phrase and username associated with the account that I want to import on subsequent pages, it eventually asks me to "Secure your account with a password" and asks for me to enter "Password" and "Confirm" (password)... but i was expecting it instead show me a label like "Enter your password" and to have just shown a "Password" input field instead to unlock the encrypted account (since we're importing an existing account instead of creating a new account or specifically changing the password associated with an account). I was able to enter a new password and confirmed that new password without having to enter the existing password at all. Lastly i clicked "Confirm Account Creation".

@Tbaut
Copy link
Collaborator

Tbaut commented Jul 5, 2018

image

  • We should probably not show the loading bar and the icon at this stage.
  • We should not prefill the name with whatever name was given before.
  • The account name and icon should eventually only be shown in the latest stage, when selecting the password (as it has an icon, address, and a name):
    image

@amaury1093
Copy link
Collaborator

We should probably not show the loading bar and the icon at this stage.

There's one big reason to show the icon+address at this stage: to make sure we retyped the correct seed phrase. I remember my address's ending and my identicon, so if my retyping went wrong I'd know immediately.

@Tbaut
Copy link
Collaborator

Tbaut commented Jul 6, 2018

👍 yup showing it before confirming the account creation makes sense. Showing the address and icon with (no name) wasn't nice though.

@Tbaut Tbaut changed the title Import account page asks user to create and confirm new password instead of asking them to entering the existing password associated with the encrypted account they wish to import Change account import workflow Jul 17, 2018
@Tbaut
Copy link
Collaborator

Tbaut commented Jul 17, 2018

This could be changed while fixing: #138

@Tbaut Tbaut added this to the 0.3-beta milestone Jul 17, 2018
@axelchalon
Copy link
Contributor

axelchalon commented Oct 26, 2018

This issue is fixed afaik? (since #181)

@Tbaut
Copy link
Collaborator

Tbaut commented Oct 26, 2018

yes, it's fixed

@Tbaut Tbaut closed this as completed Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants