Update metadate to support payable constructors #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCastano
changed the base branch from
master
to
hc-make-constructors-non-payable
HCastano
changed the base branch from
hc-make-constructors-non-payable
to
master
HCastano
changed the base branch from
master
to
hc-make-constructors-non-payable
HCastano
force-pushed
the
hc-non-payable-constructors-metadata
branch
from
f75135c
to
6275cc3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
- Coverage 78.83% 78.33% -0.50%
==========================================
Files 252 252
Lines 9391 9395 +4
==========================================
- Hits 7403 7360 -43
- Misses 1988 2035 +47
Continue to review full report at Codecov.
|
This was referenced Jan 10, 2022
cmichi
reviewed
Jan 14, 2022
| @@ -508,7 +536,7 @@ impl<S, P, R> MessageSpecBuilder<S, Missing<state::Mutates>, P, R> { | |||
| } | |||
|
|
|||
| impl<S, M, R> MessageSpecBuilder<S, M, Missing<state::IsPayable>, R> { | |||
| /// Sets if the message is mutable, thus taking `&mut self` or not thus taking `&self`. | |||
| /// Sets if the message is payable, thus accepting value for the caller. | |||
cmichi
approved these changes
Jan 14, 2022
HCastano
force-pushed
the
hc-non-payable-constructors-metadata
branch
from
6275cc3
to
a6b075a
Compare
HCastano
added a commit
that referenced
this pull request
Jan 19, 2022
cmichi
added a commit
that referenced
this pull request
Jan 20, 2022
* Bump rc7 to rc8 * Update changelog * Apply suggestions from code review Co-authored-by: GreenBaneling | Supercolony <XgreenX9999@gmail.com> * Fix `polkadot-js/api` links + mention PR #1100 * `s/polkadots/polkadot/g` * Fix typo: contract ➜ contracts Co-authored-by: GreenBaneling | Supercolony <XgreenX9999@gmail.com> Co-authored-by: Hernando Castano <hernando@hcastano.com>
xgreenx
pushed a commit
to Supercolony-net/ink
that referenced
this pull request
Feb 8, 2022
* Add `payable` field to constructor metadata * Bump metadata version to `V3` * Update metadata tests for `payable` constructors
xgreenx
added a commit
to Supercolony-net/ink
that referenced
this pull request
Feb 8, 2022
* Bump rc7 to rc8 * Update changelog * Apply suggestions from code review Co-authored-by: GreenBaneling | Supercolony <XgreenX9999@gmail.com> * Fix `polkadot-js/api` links + mention PR use-ink#1100 * `s/polkadots/polkadot/g` * Fix typo: contract ➜ contracts Co-authored-by: GreenBaneling | Supercolony <XgreenX9999@gmail.com> Co-authored-by: Hernando Castano <hernando@hcastano.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1065. I figured I'd split it out to make reviews easier.