-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dynamic storage allocator #1148
Conversation
Goodnight Sweet Prince 🥲
Codecov Report
@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
+ Coverage 75.40% 78.70% +3.29%
==========================================
Files 254 243 -11
Lines 9446 9242 -204
==========================================
+ Hits 7123 7274 +151
+ Misses 2323 1968 -355
Continue to review full report at Codecov.
|
Glad to see this. To be honest, the dynamic storage allocator should not be revived later on since it was more or less a failed experiment. If we want to support use cases that are impossible otherwise we should rather add proper support in |
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑
These are the results when building the
Link to the run | Last update: Mon Feb 28 09:23:15 CET 2022 |
@HCastano Could you do that please? |
Yet another follow up related to #1111.
In this case we can safely remove the dynamic storage allocator and related code since we
removed all collections which can allocate storage dynamically.
Will need follow up in the ink! documentation portal and workshop.