Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution context parameters in DNS example #723

Merged
merged 2 commits into from
Mar 6, 2021

Conversation

austinabell
Copy link
Contributor

  • Endowment and gas limit were flipped, which confused me when I used as reference, so figured I'd fix

I automatically format, so if you want me to keep the changes minimal and revert those, let me know :)

@austinabell austinabell changed the title Fix execution content variables in DNS example Fix execution context variables in DNS example Mar 6, 2021
@austinabell austinabell changed the title Fix execution context variables in DNS example Fix execution context parameters in DNS example Mar 6, 2021
@Robbepop
Copy link
Collaborator

Robbepop commented Mar 6, 2021

thank you very much for the fix. please also fix your formatting problems in the PR so we can merge. :)

@austinabell
Copy link
Contributor Author

thank you very much for the fix. please also fix your formatting problems in the PR so we can merge. :)

Ah, my apologies, didn't notice the custom formatting file and I guess I was formatting the file specifically

@codecov-io
Copy link

codecov-io commented Mar 6, 2021

Codecov Report

Merging #723 (50c2aad) into master (2c431e5) will decrease coverage by 3.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
- Coverage   83.62%   80.53%   -3.10%     
==========================================
  Files         163      163              
  Lines        7475     7475              
==========================================
- Hits         6251     6020     -231     
- Misses       1224     1455     +231     
Impacted Files Coverage Δ
crates/lang/ir/src/ir/contract.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/ir/src/ir/ink_test.rs 0.00% <0.00%> (-87.50%) ⬇️
crates/lang/ir/src/ir/item_mod.rs 59.73% <0.00%> (-32.22%) ⬇️
crates/lang/ir/src/ir/config.rs 68.08% <0.00%> (-23.41%) ⬇️
crates/lang/ir/src/ir/item_impl/mod.rs 68.10% <0.00%> (-23.28%) ⬇️
crates/lang/ir/src/ir/chain_extension.rs 69.67% <0.00%> (-22.59%) ⬇️
crates/lang/ir/src/ir/item/event.rs 68.65% <0.00%> (-20.90%) ⬇️
crates/lang/ir/src/ir/item_impl/impl_item.rs 40.00% <0.00%> (-20.00%) ⬇️
crates/lang/ir/src/ir/item/storage.rs 61.29% <0.00%> (-19.36%) ⬇️
crates/lang/ir/src/ir/item_impl/message.rs 78.04% <0.00%> (-18.30%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c431e5...50c2aad. Read the comment docs.

Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix! :)

@Robbepop Robbepop merged commit adc42a5 into use-ink:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants