Implement seal_debug_message
#792
Conversation
Let's be honest: It was about time. 😅 |
Co-authored-by: Robin Freyler <robin.freyler@gmail.com>
I personally wouldn't introduce yet another crate feature and instead document the expected behavior when using this SEAL macro/function without respecting the SEAL unstable feature upon compilation. |
| #[cfg(feature = "ink-debug")] | ||
| /// Call `seal_debug_message` with the supplied UTF-8 encoded message. | ||
| /// | ||
| /// If debug message recording is disabled in the contracts pallet, the first call to will |
There was a problem hiding this comment.
| /// If debug message recording is disabled in the contracts pallet, the first call to will | |
| /// If debug message recording is disabled in the contracts pallet, the first call will |
| /// Call `seal_debug_message` with the supplied UTF-8 encoded message. | ||
| /// | ||
| /// If debug message recording is disabled in the contracts pallet, the first call to will | ||
| /// return LoggingDisabled error, and further calls will be a no-op to avoid the cost of calling |
There was a problem hiding this comment.
please make it LoggingDisabled. somehow I cannot make a suggestion here.
There was a problem hiding this comment.
Yeah sorry because I merged it already 🙈
Companion PR for paritytech/substrate#8773, which replaces
seal_printlnwithseal_debug_message.I've added some convenience macros
debug_print!anddebug_println!, let me know what you think.todo
printlnink-docs#19seal_debug_messageis now anunstablefeature in the contracts pallet, should we hide it behindink-unstable? Or just add a comment that the node needs to compiled with"pallet-contracts/unstable-interface"enabled.ink-debugfeature which makesdebug_messageand thedebug_print*macro a noop. Could modifycargo-contractto add/remove this feature from the contract/