-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clients]: inconsitent behaviour w.r.t to default port number in URL #554
Comments
So this issue implies switching to |
Ideally jsonrpsee would provide the default port number if missing but that requires hyperium/http#509 to be fixed. Thus, I don't know but we could use |
Imo consistency trumps the usefulness of providing a default port. |
Closed by #545 |
The clients act different when parsing the
URL/URI
whereas:url::Url::parse
which provides the default port number if missinghttp::Uri
which doesn't provide the default port number if missing but URI: how to distinguish from invalid port vs no port number hyperium/http#509 blocks us from applying this ourselves because the URL might get rejected if a bad port number such as-99
was enteredThe reason why we use
http::Uri
in the WsClient is because it supports relative URIs that is needed to handle redirections.The text was updated successfully, but these errors were encountered: