Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The http-server feature no longer has access to Middleware #759

Closed
ljedrz opened this issue May 9, 2022 · 2 comments
Closed

The http-server feature no longer has access to Middleware #759

ljedrz opened this issue May 9, 2022 · 2 comments

Comments

@ljedrz
Copy link

ljedrz commented May 9, 2022

Discovered in https://github.com/AleoHQ/snarkOS/pull/1763, which caused the following errors:

error[E0433]: failed to resolve: could not find `core` in `jsonrpsee`
  --> rpc/src/context.rs:26:5
   |
26 |     core::{middleware::Middleware, Error as JsonrpseeError},
   |     ^^^^ could not find `core` in `jsonrpsee`

error[E0432]: unresolved import `jsonrpsee::core`
  --> rpc/src/context.rs:26:5
   |
26 |     core::{middleware::Middleware, Error as JsonrpseeError},
   |     ^^^^ could not find `core` in `jsonrpsee`

I double-checked it with a dummy crate that has a single dependency:

jsonrpsee = { version = "0.12", features = ["http-server"] }

and it fails to compile with the following import:

use jsonrpsee::core::middleware::Middleware;

While it does work with the server feature instead, I'd expect Middleware to be available for HTTP servers as well.

@niklasad1
Copy link
Member

@niklasad1
Copy link
Member

Closed by #760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants