Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core client]: TransportSenderT trait has WebSocket specific details #825

Closed
niklasad1 opened this issue Jul 14, 2022 · 2 comments
Closed

[core client]: TransportSenderT trait has WebSocket specific details #825

niklasad1 opened this issue Jul 14, 2022 · 2 comments

Comments

@niklasad1
Copy link
Member

niklasad1 commented Jul 14, 2022 •
edited
Loading

The TransportSenderT trait should be transport agnostic and send_ping and close should be either be moved to an extension trait (that may need some refactoring in the async client) or these methods needs to be clearly documented as optional.

See paritytech/subxt#596 (comment) for further information,
@niklasad1
Copy link
Member Author

I looked at the async client and implementing a extension trait for WebSocket specific stuff looks really difficult.

I will just mark and document these as optional for now.

@niklasad1
Copy link
Member Author

Fixed by #852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@niklasad1