Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CORS support from Jsonrpsee and rely on tower middleware instead #842

Closed
jsdw opened this issue Aug 3, 2022 · 1 comment · Fixed by #851
Closed

Remove CORS support from Jsonrpsee and rely on tower middleware instead #842

jsdw opened this issue Aug 3, 2022 · 1 comment · Fixed by #851
Assignees
@lexnv

Comments

@jsdw
Copy link
Collaborator

jsdw commented Aug 3, 2022 •
edited
Loading

Depends on us having #841.

Let's simplify Jsonrpsee by getting the CORS stuff out and relying on a pre-existing middleware instead.

When we do this we should have at least one example showing how to use the third party CORS middleware (eg this one; https://docs.rs/tower-http/latest/tower_http/cors/index.html)
@jsdw jsdw added this to the v1.0 milestone Aug 3, 2022
@jsdw jsdw changed the title Remove CORS support from Jsonrpsee and show example of using tower middleware instead Remove CORS support from Jsonrpsee and rely on tower middleware instead Aug 3, 2022
@lexnv lexnv mentioned this issue Aug 4, 2022
Closed
@lexnv lexnv self-assigned this Aug 10, 2022
@lexnv lexnv mentioned this issue Aug 11, 2022
Merged
@lexnv lexnv linked a pull request Aug 11, 2022 that will close this issue
Remove CORS logic #851
Merged
@jsdw jsdw removed this from the v1.0 milestone Aug 16, 2022
@niklasad1
Copy link
Member

niklasad1 commented Aug 16, 2022 •
edited
Loading

@jsdw why was this removed from the 1.0 milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lexnv lexnv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove CORS logic paritytech/jsonrpsee
3 participants
@jsdw @niklasad1 @lexnv