Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport/manager: Determine if remote peer can establish two connections with local node #189

Open
lexnv opened this issue Jul 30, 2024 · 0 comments

Comments

@lexnv
Copy link
Collaborator

lexnv commented Jul 30, 2024

Currently the transport manager can accept two connections established by the remote, however the local node can establish only one connection.

This comes from the fact that each transport will eagerly negotiate the incoming connections and then report to the transport manager that the connection has been established. Then the transport manager accepts the connection if there's a secondary slot.

Determine if the litep2p node should accept 2 incoming connections, instead of 1 incoming and 1 outgoing in the rare cases where we dial the peer and at the same time the peer connected to us. From the resource perspective, rejecting a second incoming connection would be beneficial, and would lean towards this.

Followup from: #185 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant