Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtocolSet: failed to register opened substream #252

Open
lexnv opened this issue Sep 24, 2024 · 0 comments
Open

ProtocolSet: failed to register opened substream #252

lexnv opened this issue Sep 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@lexnv
Copy link
Collaborator

lexnv commented Sep 24, 2024

Discovered during testing of substrate performance PR: paritytech/polkadot-sdk#4942

2024-09-20 05:08:31.096 ERROR tokio-runtime-worker litep2p::tcp::connection: failed to register opened substream to protocol error=ConnectionClosed
2024-09-20 05:08:31.345 ERROR tokio-runtime-worker litep2p::tcp::connection: failed to register opened substream to protocol error=ConnectionClosed
2024-09-20 05:08:31.726 ERROR tokio-runtime-worker litep2p::tcp::connection: failed to register opened substream to protocol error=ConnectionClosed
2024-09-20 05:08:32.042 ERROR tokio-runtime-worker litep2p::tcp::connection: failed to register opened substream to protocol error=ConnectionClosed
2024-09-20 05:08:32.450 ERROR tokio-runtime-worker litep2p::tcp::connection: failed to register opened substream to protocol error=ConnectionClosed
2024-09-20 05:08:32.522 ERROR tokio-runtime-worker litep2p::tcp::connection: failed to register opened substream to protocol error=ConnectionClose

Places where this may happen:

match (protocol, substream_id) {
(Some(protocol), Some(substream_id)) => {
if let Err(error) = self.protocol_set
.report_substream_open_failure(protocol, substream_id, error)
.await
{
tracing::error!(
target: LOG_TARGET,
?error,
"failed to register opened substream to protocol"
);
}
}

if let Err(error) = self.protocol_set
.report_substream_open(self.peer, protocol, direction, substream)
.await
{
tracing::error!(
target: LOG_TARGET,
?error,
"failed to register opened substream to protocol",
);

@lexnv lexnv added the bug Something isn't working label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant