Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kvdb-web] enable tests on macOS #226

Closed
ordian opened this issue Sep 25, 2019 · 2 comments · Fixed by #263
Closed

[kvdb-web] enable tests on macOS #226

ordian opened this issue Sep 25, 2019 · 2 comments · Fixed by #263

Comments

@ordian
Copy link
Member

ordian commented Sep 25, 2019

Once rustwasm/wasm-pack#717 is resolved.

@zrzka
Copy link
Contributor

zrzka commented Nov 19, 2019

The problem is in the --chrome flag (chromedriver). Incompatible driver is installed. Works fine with just --firefox.

I always ended up with installing my own chromedriver. It's also suggested in this comment.

(Permanent) Workaround for Travis CI (or even local macOS):

install:
  - curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.1/install.sh | sh
  - source ~/.nvm/nvm.sh
  - nvm install v10.5
  - npm install -g chromedriver

Chrome:

zrzka@Roberts-MacBook-Pro kvdb-web % wasm-pack test --headless --chrome
...
Running headless tests in Chrome on `http://127.0.0.1:56954/`
Try find `webdriver.json` for configure browser's capabilities:
Not found
running 1 test

test indexed_db::reopen_the_database_with_more_columns ... ok

test result: ok. 1 passed; 0 failed; 0 ignored
console.log div contained:
    Upgrading or creating the database to version None, columns 1
    Previous version: 1, columns 0
    Upgrading or creating the database to version Some(2), columns 3
    Previous version: 2, columns 2

zrzka@Roberts-MacBook-Pro kvdb-web %

Firefox (works fine without this workaround):

zrzka@Roberts-MacBook-Pro kvdb-web % wasm-pack test --headless --firefox
...
Running headless tests in Firefox on `http://127.0.0.1:59468/`
Try find `webdriver.json` for configure browser's capabilities:
Not found
running 1 test

test indexed_db::reopen_the_database_with_more_columns ... ok

test result: ok. 1 passed; 0 failed; 0 ignored
console.log div contained:
    Upgrading or creating the database to version None, columns 1
    Previous version: 1, columns 0
    Upgrading or creating the database to version Some(2), columns 3
    Previous version: 2, columns 2

zrzka@Roberts-MacBook-Pro kvdb-web %

@ordian
Copy link
Member Author

ordian commented Nov 19, 2019

@zrzka thanks for the analysis, I'll submit a PR with the suggested workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants