Transactions hashes missing in trace_replayBlockTransactions method result

[adirmola]

Before filing a new issue, please provide the following information.

I'm running:

• Which Parity version?: 1.12.0
• Which operating system?: Windows
• How installed?: via installer
• Are you fully synchronized?: yes
• Which network are you connected to?: ropsten
• Did you try to restart the node?: yes

Hi,

When running the method "trace_replayBlockTransactions" with "stateDiff" parameter I'm getting back a list of stateDiff of all transaction in a specific block.
The problem is that the result doesn't include the transactions hashes so we cant link the specific stateDiff to the related transaction.

For example, if running (on ropsten) the following:
curl --data '{"method":"trace_replayBlockTransactions","params":["0x32d8e6",["trace"]],"id":1,"jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST localhost:8545

I'm getting:

{
    'jsonrpc':  '2.0',
     'result':  [
        {
            'output':  '0x000000000000000000000000202934ddeda0d38f30a70e9cf888c13afc2792bc',
             'stateDiff':  {
                '0x202934ddeda0d38f30a70e9cf888c13afc2792bc':  {
                    'balance':  { '+':  '0x0'},
                     'code':  { '+':  '0x6080..."},
                     'nonce':  { '+':  '0x1'},
                     'storage':  {
                        '0x0000000000000000000000000000000000000000000000000000000000000000':  {
                            '+':  '0x000000000000000000000000e7a043b5db22472df387d3cca173b6227b37f1f4' }
                    }
                },
                 '0xb2d9a807815d6e9afff805b835cd06cb990db423':  {
                    'balance':  '=',
                     'code':  '=',
                     'nonce':  { '*':  {'from':  '0x7', 'to':  '0x8' }},
                     'storage':  { }
                },
                 '0xe24246e6dcbb07bc15a1f9c3833fc1877df4c80e':  {
                    'balance':  { '*':  { 'from':  '0x7c5e833076332a74ad2','to':  '0x7c5e835123266a208d2' } },
                     'code':  '=',
                     'nonce':  '=',
                     'storage':  {}
                },
                 '0xe7a043b5db22472df387d3cca173b6227b37f1f4':  {
                    'balance':  { '*':  { 'from':  '0xd53e81b3de42cd4','to':  '0xd51dd4c09e96ed4' }},
                     'code':  '=',
                     'nonce':  { '*':  {'from':  '0x2a', 'to':  '0x2b' } },
                     'storage':  { }
                }
            },
             'trace':  [],
             'vmTrace':  None
        },
....],
     'id':  1
}

which you can see doesn't include the transaction hash.

Meanwhile (after checking with parity team on gitter) we can assume that the result of "trace_replayBlockTransactions" is in order with transactions index on the block.
Obvious, it isn't the straightforward way to handle this issue.

So adding the transaction hash to the result will be great.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

This issue now has a funding of 0.15 ETH (85.92 USD @ $572.77/ETH) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $9,353.54 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work has been started.

These users each claimed they can complete the work by 8 months, 2 weeks ago.
Please review their action plans below:

1) shamardy has started work.

working on this

Learn more on the Gitcoin Issue Details page.

[vs77bb]

@shamardy Hello - any update on your side? Would appreciate a WIP PR for review whenever is possible 🙂

[shamardy]

@vs77bb sorry for the delay it took me some time to run the parity node.

I ran parity using
parity --chain=ropsten --pruning=archive --jsonrpc-apis traces --base-path ./foobar

then I ran the following command after syncing with the block
curl -X POST -H "Content-Type: application/json" -o "output.txt" --data "{\"jsonrpc\":\"2.0\",\"id\":1,\"method\":\"trace_replayBlockTransactions\",\"params\":[\"0x8265\",[\"trace\"]]}" http://127.0.0.1:8545

and I got a normal output that shows transactions
{"jsonrpc":"2.0","result":[{"output":"0x","stateDiff":null,"trace":[{"action":{"callType":"call","from":"0x13c0127b66b336a644cc36c2e44eadc5fcd8b79d","gas":"0x37b38","input":"0x51a34eb80000000000000000000000000000000000000000000000007ce647efa8b98000","to":"0x06eadbd0b793d7614bf42d8d09980bf345ec748b","value":"0x0"},"result":{"gasUsed":"0x12bb3","output":"0x"},"subtraces":2,"traceAddress":[],"type":"call"},{"action":{"callType":"call","from":"0x06eadbd0b793d7614bf42d8d09980bf345ec748b","gas":"0x31217","input":"0xe16c7d98636f6e7472616374617069000000000000000000000000000000000000000000","to":"0x2cccf5e0538493c235d1c5ef6580f77d99e91396","value":"0x0"},"result":{"gasUsed":"0x334","output":"0x000000000000000000000000b4fe7aa695b326c9d219158d2ca50db77b39f99f"},"subtraces":0,"traceAddress":[0],"type":"call"},{"action":{"callType":"call","from":"0x06eadbd0b793d7614bf42d8d09980bf345ec748b","gas":"0x30b4a","input":"0x51a34eb80000000000000000000000000000000000000000000000007ce647efa8b98000","to":"0xb4fe7aa695b326c9d219158d2ca50db77b39f99f","value":"0x0"},"result":{"gasUsed":"0x24d","output":"0x0000000000000000000000000000000000000000000000000000000000000001"},"subtraces":0,"traceAddress":[1,3,11,0],"type":"call"}],"vmTrace":null}],"id":1}

I didn't query block "0x32d8e6" the same as @adirmola because it would take me some time to sync to it. Maybe this block had no transactions?

[shamardy]

sorry I forgot to write the results with stateDiff, for this I ran this command:
curl -X POST -H "Content-Type: application/json" -o "output.txt" --data "{\"jsonrpc\":\"2.0\",\"id\":1,\"method\":\"trace_replayBlockTransactions\",\"params\":[\"0x8265\",[\"trace\",\"stateDiff\"]]}" http://127.0.0.1:8545

results:
{"jsonrpc":"2.0","result":[{"output":"0x","stateDiff":{"0x06eadbd0b793d7614bf42d8d09980bf345ec748b":{"balance":"=","code":"=","nonce":"=","storage":{"0x0000000000000000000000000000000000000000000000000000000000000002":{"*":{"from":"0x0000000000000000000000000000000000000000000000000000000000008255","to":"0x0000000000000000000000000000000000000000000000000000000000008265"}},"0x000000000000000000000000000000000000000000000000000000000000000b":{"*":{"from":"0x0000000000000000000000000000000000000000000000007ce66c50e2840000","to":"0x0000000000000000000000000000000000000000000000007ce647efa8b98000"}}}},"0x13c0127b66b336a644cc36c2e44eadc5fcd8b79d":{"balance":{"*":{"from":"0x2da34a0533deaff85","to":"0x2da2d9f54411d6785"}},"code":"=","nonce":{"*":{"from":"0x9fd","to":"0x9fe"}},"storage":{}},"0xcf00ffd997ad14939736f026006498e3f099baaf":{"balance":"=","code":"=","nonce":"=","storage":{"0x070c259bc5bb5442a0e39365770918681724c9f5cca6888e9ff72def394851f7":{"*":{"from":"0x0000000000000000000000000000000000000000000000185de5cf8fa04dc000","to":"0x0000000000000000000000000000000000000000000000185de463c35e64c000"}}}},"0xfcb9fb8d0e02d1dee561d2534c821af2ad8a5d13":{"balance":{"*":{"from":"0x1035baf0b0016f7db1b","to":"0x1035bb60bff13c5731b"}},"code":"=","nonce":"=","storage":{}}},"trace":[],"vmTrace":null}],"id":1}

Again It has the transactions

[adirmola]

Hey @shamardy,
I think u missing the point.
I didn't say there isn't transactions but the transactions don't retrieved with their hashes.

[gitcoinbot]

@shamardy Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[shamardy]

submitted a pull request:
#8883

[gitcoinbot]

@shamardy Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• warning (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[shamardy]

Yes, I am still working on this issue, waiting for response from @debris in #8883

[vs77bb]

Thanks for the update @shamardy - snoozing Gitcoin bot for a bit here.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work for 0.15 ETH (66.04 USD @ $440.25/ETH) has been submitted by:

1. @shamardy

@vs77bb please take a look at the submitted work:

• PR by @shamardy

---

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
  $16,269.39 more funded OSS Work available on the Gitcoin Issue Explorer

[shamardy]

@vs77bb can you please approve this. Thanks.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

The funding of 0.15 ETH (74.61 USD @ $497.38/ETH) attached to this issue has been approved & issued to @shamardy.

• Learn more at on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $30,040.26 more funded OSS Work available on the Gitcoin Issue Explorer