Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

add_sync_notifier in EthPubSubClient holds on to a Client for too long #10689

Merged
merged 1 commit into from
May 23, 2019
Merged

add_sync_notifier in EthPubSubClient holds on to a Client for too long #10689

merged 1 commit into from
May 23, 2019

Conversation

dvdplm
Copy link
Collaborator

@dvdplm dvdplm commented May 22, 2019 •
edited
Loading

Need a weak ref so shutdown works.

Somewhat related to #10683

@dvdplm dvdplm mentioned this pull request May 22, 2019
Merged
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. labels May 22, 2019
@dvdplm dvdplm merged commit d250f34 into master May 23, 2019
dvdplm added a commit that referenced this pull request May 23, 2019
@dvdplm
Merge branch 'master' into dp/fix/move-step-service-into-clique
70b1e0c 
* master:
  add_sync_notifier in EthPubSubClient holds on to a Client for too long (#10689)
  Don't panic if extra_data is longer than VANITY_LENGTH (#10682)
  docs: evmbin - Update Rust docs (#10658)
  Remove annoying compiler warnings (#10679)
  Reset blockchain properly (#10669)
@ordian ordian deleted the dp/fix/pubsub-notifier-holds-on-to-arc branch May 23, 2019 10:02
ordian added a commit that referenced this pull request May 23, 2019
@ordian
Merge branch 'master' into ao-upgrade-ethereum-types
3b9f715 
* master:
  add_sync_notifier in EthPubSubClient holds on to a Client for too long (#10689)
  Don't panic if extra_data is longer than VANITY_LENGTH (#10682)
  docs: evmbin - Update Rust docs (#10658)
  Remove annoying compiler warnings (#10679)
  Reset blockchain properly (#10669)
This was referenced Jun 6, 2019
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@tomusdrw tomusdrw tomusdrw approved these changes

@seunlanlege seunlanlege Awaiting requested review from seunlanlege

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvdplm @tomusdrw @niklasad1