This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Extract the Engine trait #10958
Merged
Merged
Extract the Engine trait #10958
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
ddeef45
Add client-traits crate
dvdplm 0d49c45
New crate `machine`
dvdplm 0465e6b
Use new machine and client-traits crates in ethcore
dvdplm 50ca45a
Use new crates machine and client-traits instead of ethcore where app…
dvdplm 29d4095
Fix tests
dvdplm cd6e0e2
Don't re-export so many types from ethcore::client
dvdplm 2477cbd
Fixing more fallout from removing re-export
dvdplm 51ba2f4
Merge branch 'master' into dp/chore/move-machine-to-own-crate
dvdplm c84a01f
fix test
dvdplm f2497f4
More fallout from not re-exporting types
dvdplm 1e43534
Add some docs
dvdplm 6d83cf2
cleanup
dvdplm e04d188
import the macro edition style
dvdplm b6e91de
Merge branch 'master' into dp/chore/move-machine-to-own-crate
dvdplm bac7268
Tweak docs
dvdplm 978eb88
Add missing import
dvdplm d6273a7
Merge branch 'master' into dp/chore/move-machine-to-own-crate
dvdplm 18d6a94
remove unused ethabi_derive imports
dvdplm d5700d9
Use latest ethabi-contract
dvdplm 83bb140
Move many traits from ethcore/client/traits to client-traits crate
dvdplm d96fff3
Move snapshot related traits to the engine crate (eew)
dvdplm 33aa152
Move a few snapshot related types to common_types
dvdplm 9b70856
fix warning
dvdplm f76e5ed
Gradually introduce new engine crate: snapshot
dvdplm 5b3a8ca
ethcore typechecks with new engine crate
dvdplm cecd69c
Sort out types outside ethcore
dvdplm c5ab534
Add an EpochVerifier to ethash and use that in Engine.epoch_verifier()
dvdplm 45c0497
Document pub members
dvdplm b11a21f
Sort out tests
dvdplm af485cc
Add test-helpers feature and move EngineSigner impl to the right place
dvdplm f617bcb
Sort out tests
dvdplm 64b5c60
Sort out tests and refactor verification types
dvdplm b1b6b46
Fix missing traits
dvdplm 881b71f
More missing traits
dvdplm ddca9ee
Fix tests and cleanup
dvdplm d7d3f4b
cleanup
dvdplm b2f8be6
Put back needed logger import
dvdplm 8ab2a02
Don't rexport common_types from ethcore/src/client
dvdplm 4aef5f2
Remove files no longer used
dvdplm 951f63e
Get rid of itertools
dvdplm 1c42cc1
Move a few more traits from ethcore to client-traits: BlockChainReset…
dvdplm 07b1c2d
Move ProvingBlockChainClient to client-traits
dvdplm 7e5e4bc
Don't re-export ForkChoice and Transition from ethcore
dvdplm b244bfb
Address grumbles: sort imports, remove commented out code
dvdplm 37be7b2
Merge branch 'master' into dp/chore/extract-engine-trait
dvdplm 88cfa7f
Fix merge resolution error
dvdplm dcaf256
Merge branch 'master' into dp/chore/extract-engine-trait
ordian 60a03b2
merge failure
dvdplm c75738e
Merge branch 'master' into dp/chore/extract-engine-trait
dvdplm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort?