Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Improve error origin reporting for companion-related errors #351

Closed
joao-paulo-parity opened this issue Jan 5, 2022 · 3 comments
Closed
Labels
enhancement New feature or request UX

Comments

@joao-paulo-parity
Copy link
Contributor

Problem: The error from #349 happened due to a parsing error for the description of paritytech/cumulus#870 (comment), but it was reported on the Substrate PR paritytech/substrate#10463 (comment) with no way to trace it back to the source of the problem without looking at the logs.

Solution: The error message should include where the error originated from, as in

Error ...
While trying to parse the description of paritytech/cumulus#870

@joao-paulo-parity
Copy link
Contributor Author

This might have been fixed by #354

@Vovke Vovke added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists labels Apr 12, 2022
@joao-paulo-parity joao-paulo-parity added the enhancement New feature or request label Apr 15, 2022
@mordamax
Copy link
Contributor

@joao-paulo-parity is that it?

image

or some other cases still missing for this scope of issue?

@joao-paulo-parity
Copy link
Contributor Author

This one is about a different problem. That being said I think it is working properly now, so it's better to create a new issue in case this comes up again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request UX
Projects
None yet
Development

No branches or pull requests

3 participants