Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mio-named-pipes with mio 0.7.2 #30

Closed
alvinhochun opened this issue Oct 5, 2020 · 2 comments · Fixed by #32
Closed

Replace mio-named-pipes with mio 0.7.2 #30

alvinhochun opened this issue Oct 5, 2020 · 2 comments · Fixed by #32

Comments

@alvinhochun
Copy link

Windows named pipe is now part of mio 0.7: tokio-rs/mio#1351

@Xanewok
Copy link
Contributor

Xanewok commented Jan 22, 2021

That's currently blocked on tokio-rs/tokio#3118, because Tokio removed its PollEvented struct from the 1.0 public API - it's great from the stability guarantee PoV but unfortunately it prevents us from upgrading mio::windows::NamedPipe to something that implements Async* traits.

The alternative is to reimplement PollEvented-like facility here but that seems like a big cost which may not outweight its benefits for now.

@rustdesk
Copy link

I use named_pipe in tokio v1, but some API change to parity-tokio-ipc. https://github.com/rustdesk/rustdesk/blob/master/libs/parity-tokio-ipc/src/win.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants