Loading local Dapps from FS. #1214

tomusdrw · 2016-06-02T17:33:55Z

gavofyork · 2016-06-03T09:37:10Z

dapps/src/page/builtin.rs

+		}
+	}
+
+	pub fn with_prefix(app: T, prefix: String) -> Self {


undocumented pub?

gavofyork · 2016-06-03T09:51:42Z

([ci skip] could have been invoked as the changes added were only comments.)

Tomasz Drwięga added 4 commits June 1, 2016 20:37

apps list to separate module

adf61fe

Preparing to support serving files from disk

d4a9042

Serving files from disk

d8d417a

Using dapps path from CLI

d701d05

tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Jun 2, 2016

gavofyork reviewed Jun 3, 2016
View reviewed changes

dapps/src/page/builtin.rs

}

}

pub fn with_prefix(app: T, prefix: String) -> Self {

Copy link

Contributor

gavofyork Jun 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undocumented pub?

Adding more docs

7ed76d7

gavofyork merged commit bb1b8cc into master Jun 3, 2016

gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Jun 3, 2016

tomusdrw deleted the fs-dapps branch June 11, 2016 15:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Loading local Dapps from FS. #1214

Loading local Dapps from FS. #1214

tomusdrw commented Jun 2, 2016 •

edited

Loading

gavofyork Jun 3, 2016

gavofyork commented Jun 3, 2016

Loading local Dapps from FS. #1214

Loading local Dapps from FS. #1214

Conversation

tomusdrw commented Jun 2, 2016 • edited Loading

gavofyork Jun 3, 2016

Choose a reason for hiding this comment

gavofyork commented Jun 3, 2016

tomusdrw commented Jun 2, 2016 •

edited

Loading