Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Blockchain repair on missing state root #1646

Merged
merged 3 commits into from
Jul 17, 2016
Merged

Blockchain repair on missing state root #1646

merged 3 commits into from
Jul 17, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Jul 17, 2016

No description provided.

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label Jul 17, 2016
{
let mut best_block = self.best_block.write();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lock and two following locks must be held together

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment to that effect? the one above it doesn't indicate that.

@coveralls
Copy link

coveralls commented Jul 17, 2016

Coverage Status

Coverage decreased (-0.05%) to 76.337% when pulling 2a0fa0e on bc-lock into 5ab18d1 on master.

@arkpar arkpar added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 17, 2016
@arkpar
Copy link
Collaborator Author

arkpar commented Jul 17, 2016

Test pending

@coveralls
Copy link

coveralls commented Jul 17, 2016

Coverage Status

Coverage decreased (-0.03%) to 76.348% when pulling 0d39b30 on bc-lock into 5ab18d1 on master.

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jul 17, 2016
@gavofyork gavofyork merged commit dd17c76 into master Jul 17, 2016
@gavofyork gavofyork deleted the bc-lock branch July 17, 2016 21:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-pleasereview 🤓 Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants