Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Unlock account with timeout for geth compatibility #1854

Merged
merged 2 commits into from
Aug 5, 2016
Merged

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Aug 5, 2016

closes #1838

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label Aug 5, 2016
@coveralls
Copy link

coveralls commented Aug 5, 2016

Coverage Status

Coverage increased (+0.06%) to 86.758% when pulling 4858c1a on unlock-timer into 725d320 on master.

@gavofyork
Copy link
Contributor

travis failing?

@coveralls
Copy link

coveralls commented Aug 5, 2016

Coverage Status

Coverage decreased (-0.3%) to 86.369% when pulling f95eef0 on unlock-timer into 725d320 on master.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 5, 2016
@gavofyork gavofyork merged commit 2f52425 into master Aug 5, 2016
@gavofyork gavofyork deleted the unlock-timer branch August 5, 2016 21:33
arkpar added a commit that referenced this pull request Aug 6, 2016
* Unlock account with timeout for geth compatibility

* Fixed test
arkpar added a commit that referenced this pull request Aug 6, 2016
* Unlock account with timeout for geth compatibility

* Fixed test
arkpar added a commit that referenced this pull request Aug 6, 2016
* Unlock account with timeout for geth compatibility

* Fixed test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make personal_unlockAccount behave as with Geth when --geth
3 participants