Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Polishing Actually enable fat db pr (#1974) #2048

Merged
merged 21 commits into from
Oct 3, 2016
Merged

Polishing Actually enable fat db pr (#1974) #2048

merged 21 commits into from
Oct 3, 2016

Conversation

debris
Copy link
Collaborator

@debris debris commented Sep 5, 2016

finishes #1974 using #2014

Should be merged only if we decide to carry on with user defaults (#2014).

gavofyork and others added 16 commits August 21, 2016 20:45
@gavofyork
Actually enable fat db, and do RPCs for it.
8fc4f28
@gavofyork
Implement HashDB traits for AccountDB.
60aba63
@debris
user defaults
ed99247
@debris
finished user defaults
bf8bf17
@debris
user defaults are network-dependent
ac24cfd
@debris
Merge branch 'master' of github.com:ethcore/parity into user_default
74a168e
@debris
added tests for newly added functions, logger is initialized first
edb52c3
@debris
Merge branch 'master' into user_default
4f5fcb2
@debris
dir cleanup in progress
d28b37a
@debris
Merge branch 'master' into user_default
e349223
@debris
user_file is placed next to snapshots
79c7dc9
@debris
Merge branch 'master' of github.com:ethcore/parity into user_default
0e788d6
@debris
Merge branch 'master' into actually-enable-fat-db
223dee0
@debris
Merge branch 'user_default' into actually-enable-fat-db
2bd19a5
@debris
Merge branch 'master' of github.com:ethcore/parity into user_default
7bd504b
@debris
Merge branch 'user_default' into polishing-enable-fat-db
b682191
@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label Sep 5, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 84.906% when pulling b682191 on polishing-enable-fat-db into 4e466f0 on master.

@debris debris added A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 10, 2016
@rphmeier rphmeier added the M4-core ⛓ Core client code / Rust. label Sep 13, 2016
@gavofyork
Copy link
Contributor

will need resolving

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. A8-looksgood 🦄 Pull request is reviewed well. labels Sep 22, 2016
gavofyork
gavofyork suggested changes Sep 22, 2016
View reviewed changes
parity/cli.rs
--fat-db BOOL Build appropriate information to allow enumeration
of all accounts and storage keys. Doubles the size
of the state database. BOOL may be one of on,
off. [default: off].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have an auto/last option now, too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here: https://github.com/ethcore/parity/pull/2048/files#diff-a446157098e33897a7686a206229874aR223

@gavofyork gavofyork mentioned this pull request Sep 22, 2016
Closed
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4b9afed on polishing-enable-fat-db into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4b9afed on polishing-enable-fat-db into * on master*.

@debris debris added A0-pleasereview 🤓 Pull request needs code review. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Sep 27, 2016
@gavofyork
Copy link
Contributor

conflicts...

@gavofyork gavofyork added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 27, 2016
@debris
Copy link
Collaborator Author

debris commented Sep 27, 2016

resolved :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.06% when pulling 8cb9f9c on polishing-enable-fat-db into fb92a98 on master.

@gavofyork
Copy link
Contributor

net_connect test is failing - unrelated?

@gavofyork gavofyork added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Sep 27, 2016
@debris
Copy link
Collaborator Author

debris commented Sep 28, 2016

definitely

@debris
Copy link
Collaborator Author

debris commented Sep 28, 2016

I restarted travis job

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Sep 30, 2016
@gavofyork gavofyork merged commit 06fe768 into master Oct 3, 2016
@gavofyork gavofyork deleted the polishing-enable-fat-db branch October 3, 2016 09:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gavofyork gavofyork gavofyork requested changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@debris @coveralls @gavofyork @rphmeier