Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Update json test suite #2574

Merged
merged 2 commits into from
Oct 12, 2016
Merged

Update json test suite #2574

merged 2 commits into from
Oct 12, 2016

Conversation

keorn
Copy link

@keorn keorn commented Oct 11, 2016

One new failing, but I think its an issue with format:

thread 'json_tests::homestead_chain::BlockchainTests_Homestead_bcSuicideIssue' panicked at 'called `Result::unwrap()` on an `Err` value: Syntax(Custom("Duplicate field `code`
"), 37519, 8)', ../src/libcore/result.rs:799

@keorn keorn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M4-core ⛓ Core client code / Rust. labels Oct 11, 2016
@keorn
Copy link
Author

keorn commented Oct 11, 2016

@winsvega any hint why there are duplicate keys?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 86.434% when pulling 0e92b9f on json-test-update into 86d4e5b on master.

@keorn
Copy link
Author

keorn commented Oct 11, 2016

It was there since it was passing fine through jsoncpp. Update once ethereum/tests#121 is in.

@keorn keorn added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Oct 11, 2016
@@ -36,3 +36,7 @@ declare_test!{BlockchainTests_Homestead_bcUncleHeaderValiditiy, "BlockchainTests
declare_test!{BlockchainTests_Homestead_bcUncleTest, "BlockchainTests/Homestead/bcUncleTest"}
declare_test!{BlockchainTests_Homestead_bcValidBlockTest, "BlockchainTests/Homestead/bcValidBlockTest"}
declare_test!{BlockchainTests_Homestead_bcWalletTest, "BlockchainTests/Homestead/bcWalletTest"}
declare_test!{BlockchainTests_Homestead_bcShanghaiLove, "BlockchainTests/Homestead/bcShanghaiLove"}
// Uncomment once the test is correct.
// declare_test!{BlockchainTests_Homestead_bcSuicideIssue, "BlockchainTests/Homestead/bcSuicideIssue"}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is not yet ready in ethereum/tests repo.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 86.429% when pulling 3c36090 on json-test-update into 86d4e5b on master.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 12, 2016
@arkpar arkpar merged commit 0189096 into master Oct 12, 2016
tomusdrw pushed a commit that referenced this pull request Oct 12, 2016
* update json test suite

* comment out the incomplete test

Conflicts:
	ethcore/res/ethereum/tests
arkpar pushed a commit that referenced this pull request Oct 14, 2016
* update json test suite

* comment out the incomplete test

Conflicts:
	ethcore/res/ethereum/tests
arkpar pushed a commit that referenced this pull request Oct 14, 2016
* update json test suite

* comment out the incomplete test

Conflicts:
	ethcore/res/ethereum/tests
arkpar pushed a commit that referenced this pull request Oct 15, 2016
* EIP150.1c

Conflicts:
	ethcore/res/ethereum/expanse.json
	ethcore/res/ethereum/morden.json
	ethcore/res/ethereum/tests
	ethcore/src/blockchain/blockchain.rs
	ethcore/src/ethereum/ethash.rs
	ethcore/src/evm/interpreter/mod.rs
	json/src/spec/ethash.rs

* Update json test suite (#2574)

* update json test suite

* comment out the incomplete test

Conflicts:
	ethcore/res/ethereum/tests

* Updating tests

* Adding state tests

* Updating tests

* Updating HF block

* Removing flushln [ci:skip]

* Commenting out suicide test

* New tests.

* Switch to EIP tests.

* Rename some stuff, combine transition tests.

* Fix U256 overflows.

* Name cleanups and an effort to fix tests.

* Rename back for clarity.

* Fix non-EIP-150 OOG CALLs

* New transition block number & additional EIP150 tests

* Morden transition block set; Tests updated

* Added missing test
@gavofyork gavofyork deleted the json-test-update branch November 3, 2016 11:51
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants