Don't add empty accounts to bloom #2753

arkpar · 2016-10-20T12:34:31Z

No description provided.

rphmeier · 2016-10-20T12:37:05Z

ethcore/src/state/mod.rs

@@ -340,18 +340,18 @@ impl State {

 	/// Determine whether an account exists.
 	pub fn exists(&self, a: &Address) -> bool {
-		self.ensure_cached(a, RequireCache::None, |a| a.is_some())
+		self.ensure_cached(a, RequireCache::None, false, |a| a.is_some())


could use a comment here explaining why this is consensus-critical/ensure that tests will catch it if changed.

tomusdrw · 2016-10-20T12:48:48Z

ethcore/res/ethereum/tests

@@ -1 +1 @@
-Subproject commit 862b4e3d4a9a7141af1b4aaf7dfe228a6a294614
+Subproject commit 97066e40ccd061f727deb5cd860e4d9135aa2551


Shouldn't be changed most probably.

git submodule update --init?

It is the latest commit. This change is already in master.

coveralls · 2016-10-20T13:24:56Z

Changes Unknown when pulling 8efbfe9 on bloom-clean into * on master*.

coveralls · 2016-10-20T13:57:19Z

Changes Unknown when pulling 3b37feb on bloom-clean into * on master*.

* v1.3.9 * Block import optimization (#2748) * Block import optimization * whitespace [ci:none] * Don't add empty accounts to bloom (#2753) * Incrementally calculate verification queue heap size (#2749) * incrementally calculate queue heap size * query the correct queue sizes

arkpar added A0-pleasereview 🤓 Pull request needs code review. B0-patch M4-core ⛓ Core client code / Rust. labels Oct 20, 2016

rphmeier reviewed Oct 20, 2016

View reviewed changes

arkpar force-pushed the bloom-clean branch from d3fed30 to 8efbfe9 Compare October 20, 2016 12:43

rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 20, 2016

tomusdrw reviewed Oct 20, 2016

View reviewed changes

rphmeier added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Oct 20, 2016

Don't add empty accounts to bloom

3b37feb

arkpar force-pushed the bloom-clean branch from 8efbfe9 to 3b37feb Compare October 20, 2016 13:38

arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Oct 20, 2016

arkpar merged commit ae853a7 into master Oct 20, 2016

arkpar added a commit that referenced this pull request Oct 20, 2016

Don't add empty accounts to bloom (#2753)

d2d8ca7

gavofyork deleted the bloom-clean branch November 3, 2016 11:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't add empty accounts to bloom #2753

Don't add empty accounts to bloom #2753

arkpar commented Oct 20, 2016

rphmeier Oct 20, 2016

arkpar Oct 20, 2016

tomusdrw Oct 20, 2016

rphmeier Oct 20, 2016

arkpar Oct 20, 2016

coveralls commented Oct 20, 2016

coveralls commented Oct 20, 2016

		@@ -1 +1 @@
		Subproject commit 862b4e3d4a9a7141af1b4aaf7dfe228a6a294614
		Subproject commit 97066e40ccd061f727deb5cd860e4d9135aa2551

Don't add empty accounts to bloom #2753

Don't add empty accounts to bloom #2753

Conversation

arkpar commented Oct 20, 2016

rphmeier Oct 20, 2016

Choose a reason for hiding this comment

arkpar Oct 20, 2016

Choose a reason for hiding this comment

tomusdrw Oct 20, 2016

Choose a reason for hiding this comment

rphmeier Oct 20, 2016

Choose a reason for hiding this comment

arkpar Oct 20, 2016

Choose a reason for hiding this comment

coveralls commented Oct 20, 2016

coveralls commented Oct 20, 2016