This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Dapps interface RPC #3311
Merged
Dapps interface RPC #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
jacogr
reviewed
Nov 9, 2016
| dappsInterface () { | ||
| return this._transport | ||
| .execute('parity_dappsInterface') | ||
| .then(outNumber); |
There was a problem hiding this comment.
It returns a string/IP, so would remove this line. (Just the execute is fine without a formatter)
tomusdrw
added
A3-inprogress ⏳
tomusdrw
added
A0-pleasereview 🤓
arkpar
added
A7-looksgoodtestsfail 🤖
tomusdrw
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Nov 9, 2016
* Dapps Interface RPC * Adding JS apis * Support for signer interface in proxypac and embeds * Fixing tests * fixing tests again
arkpar
pushed a commit
that referenced
this pull request
Nov 9, 2016
* Dapps Interface RPC * Adding JS apis * Support for signer interface in proxypac and embeds * Fixing tests * fixing tests again
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses #3301
NOTE:
0.0.0.0in such case we should fallback towindow.location.hostnamewindow.location.hostname == 'home.parity'we should fallback to proxy address instead of usingdappsInterface