Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixes overflow in Signer tx data #3657

Merged
merged 1 commit into from
Nov 28, 2016
Merged

Fixes overflow in Signer tx data #3657

merged 1 commit into from
Nov 28, 2016

Conversation

ngotchac
Copy link
Contributor

Fixes #3138

@ngotchac ngotchac added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M7-ui labels Nov 28, 2016
@@ -19,6 +19,7 @@

.transaction {
flex: 1;
overflow: auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't word-break: break-all be better here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to limit the container width. word-break: break-all is actually already on the Transaction data container.

@jacogr
Copy link
Contributor

jacogr commented Nov 28, 2016

Actually being removed in it's current form, so the bug will be invalid shortly, but looks good.

@jacogr jacogr added the A8-looksgood 🦄 Pull request is reviewed well. label Nov 28, 2016
@ngotchac ngotchac merged commit eec99eb into master Nov 28, 2016
@ngotchac ngotchac deleted the ng-fix-signer-data branch November 28, 2016 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants