This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
rpc -> weak to arc #5688
Merged
rpc -> weak to arc #5688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #3958 |
CraigglesO
added
A0-pleasereview 🤓
tomusdrw
approved these changes
May 24, 2017
| sync: Arc::downgrade(sync), | ||
| miner: Arc::downgrade(miner), | ||
| accounts: accounts.as_ref().map(Arc::downgrade), | ||
| client: client.clone(), |
There was a problem hiding this comment.
Instead of cloning here we could actually change the signature from &Arc<C> to Arc<C>, it would require more changes though and the result would be the same.
There was a problem hiding this comment.
You read my mind.
tomusdrw
added
A8-looksgood 🦄
arkpar
added
A7-looksgoodcantmerge 🙄
gavofyork
added
A8-looksgood 🦄
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a circular dependency, can just use arc now.