This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
use rust 1.18's retain to boost the purge performance #5801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A7-looksgoodcantmerge 🙄
|
excellent, glad that's stabilized. |
guanqun
force-pushed
the
use-retain-for-memorydb
branch
from
1c8b317
to
cd3a1c1
Compare
|
Why can't we merge this? :) Because we don't want to require a recent rust version? |
rphmeier
added
A8-looksgood 🦄
|
happy to merge it, there were just conflicts before. |
rphmeier
added
A4-awaitingci 🤖
|
Hmm. the CI is still using the old version... Probably it's just because it's still using the cached version. How can we re-trigger the CI? |
|
Checking the |
|
It passed the CI, should be ready for merge. :) |
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Therefore, we don't need to create a temporary vector.