This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
TransactionQueue improvements #5917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
rphmeier
reviewed
Jun 23, 2017
sync/src/chain.rs
Outdated
| let mut packet; | ||
| loop { | ||
| // Construct RLP | ||
| packet = RlpStream::new_list(to_send.len()); |
There was a problem hiding this comment.
rather than halving the amount of propagated every time, I think we have a RlpStream::new_list_unbounded or similar that's used in snapshot creation. Then we can always fit as many as possible into the packet.
There was a problem hiding this comment.
Thanks! Addressed. The only issue I have is that it incurs (small) additional overhead when constructing all packages, whereas the previous approach was only more expensive when the limit is actually reached.
rphmeier
added
A5-grumble 🔥
|
Other than packet construction grumble, LGTM |
tomusdrw
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
|
needs a merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 important transaction queue and propagation improvements: