Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add missing CSP for web3.site #5992

Merged
merged 5 commits into from
Jul 11, 2017
Merged

Add missing CSP for web3.site #5992

merged 5 commits into from
Jul 11, 2017

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Jul 4, 2017

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jul 4, 2017
@gavofyork gavofyork requested a review from kaikun213 July 10, 2017 17:28
@gavofyork
Copy link
Contributor

will need resolving and @kaikun213 please take a look.

@kaikun213
Copy link
Contributor

Tested it and it works fine and from my small rust knowledge the code looks good. Only request left is that we enable port 3000 too e.g. when parity is run with --no-ui-validation flag. (Disable CSP)

@gavofyork gavofyork added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 11, 2017
@gavofyork
Copy link
Contributor

ok - will leave that to @tomusdrw then

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Jul 11, 2017
@tomusdrw
Copy link
Collaborator Author

@kaikun213 updated!

kaikun213
kaikun213 approved these changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@kaikun213 kaikun213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine! Code should be fine too (as I can tell).

@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 11, 2017
@rphmeier rphmeier merged commit 02f2c61 into master Jul 11, 2017
@rphmeier rphmeier deleted the csp-fix branch July 11, 2017 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaikun213 kaikun213 kaikun213 approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomusdrw @gavofyork @kaikun213 @rphmeier