blockchain import_route

[debris]

cc @tomusdrw . You probably need it :)

[tomusdrw]

typo

[tomusdrw]

In BlockLocation::BranchBecomingCanonChain you have route and old_route and then it becomes validated_blocks and invalidated_blocks contained in ImportRoute. I'm not convinced about those names.

What about something like InsertResult (method is called insert_block) with canon_blocks and retracted_blocks or even reusing same enum instead of BlockLocation.

enum InsertResult/InsertLocation {
  CanonChain(route),
  Branch(route),
  BranchBecameCanonChain(retracted_route/invalidated_route, route)
}

[debris]

canon_blocks / retracted_blocks sounds good for me.

But regarding this enum:

enum InsertResult/InsertLocation {
  CanonChain(route),
  Branch(route),
  BranchBecameCanonChain(retracted_route/invalidated_route, route)
}

there is no reason to have route for branch / canonchain. Branch does not have a route at all, and for canon chain, route == inserted block hash. I would prefer to keep InsertResult/InsertLocation structures separate, cause it's easier to use them.

[tomusdrw]

Agreed. What about ImportRoute name?

[debris]

I'm open for other ideas. Current name comes from cpp implementation.

[tomusdrw]

I vote for keeping it consistent with cpp or calling it InsertResult. Up to you.

[gavofyork]

enacted

[gavofyork]

prefer snappier naming than the asymmetric route and old_route.