Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ValidateUnsigned and #[validate_unsigned] #2436

Open
ggwpez opened this issue Nov 21, 2023 · 5 comments
Open

Deprecate ValidateUnsigned and #[validate_unsigned] #2436

ggwpez opened this issue Nov 21, 2023 · 5 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T13-deprecation The current issue/pr is, or should be, part of a deprecation process.

Comments

@ggwpez
Copy link
Member

ggwpez commented Nov 21, 2023

Part of #2415

ValidateUnsigned can be deprecated with a rust attribute and #[validate_unsigned] by emitting a proc-macro-warning.
The logic should be moved to TransactionExtension.
@kianenigma kianenigma added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Jan 15, 2024
@ggwpez ggwpez added the T13-deprecation The current issue/pr is, or should be, part of a deprecation process. label Feb 5, 2024
@philoniare
Copy link
Contributor

@ggwpez can you assign this to me?

@kianenigma
Copy link
Contributor

@philoniare you are free to start, would be good if you open a draft PR sooner to signal you are working on this.

@kianenigma
Copy link
Contributor

FYI, this should ideally wait until #2160 is done.

@philoniare
Copy link
Contributor

Thanks for the reminder, I'll just wait until #2160 is done. Once it's in, this ticket looks pretty straightforward.

@kianenigma
Copy link
Contributor

Note that the above PR is merged, but reverted and is now tracked in #3685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T13-deprecation The current issue/pr is, or should be, part of a deprecation process.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kianenigma @ggwpez @philoniare