Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Broken links #2743

Closed
mrcnski opened this issue Dec 18, 2023 · 1 comment
Closed

[CI] Broken links #2743

mrcnski opened this issue Dec 18, 2023 · 1 comment

Comments

@mrcnski
Copy link
Contributor

mrcnski commented Dec 18, 2023

I randomly ran lychee on the repo and it found a number of false positives, but many links that are legitimately broken:

[./docs/contributor/DOCUMENTATION_GUIDELINES.md]:
✗ [ERR] file:///Users/marcin/Repos/github.com/paritytech/polkadot-sdk/docs/contributor/CODEOWNERS | Failed: Cannot find file
✗ [ERR] file:///Users/marcin/Repos/github.com/paritytech/polkadot-sdk/docs/rustfmt.toml | Failed: Cannot find file

[./polkadot/roadmap/implementers-guide/src/messaging.md]:
✗ [404] https://research.web3.foundation/en/latest/polkadot/XCMP.html | Failed: Network error: Not Found

[./bridges/docs/high-level-overview.md]:
✗ [ERR] file:///Users/marcin/Repos/github.com/paritytech/polkadot-sdk/bridges/relays/bin-substrate/src/cli/relay_headers_and_messages | Failed: Cannot find file
✗ [ERR] file:///Users/marcin/Repos/github.com/paritytech/polkadot-sdk/bridges/relays/finality | Failed: Cannot find file
✗ [ERR] file:///Users/marcin/Repos/github.com/paritytech/polkadot-sdk/bridges/relays/messages | Failed: Cannot find file
✗ [ERR] file:///Users/marcin/Repos/github.com/paritytech/polkadot-sdk/bridges/relays/parachains | Failed: Cannot find file

[./substrate/frame/sudo/README.md]:
⧖ [TIMEOUT] https://docs.rs/pallet-sudo/latest/pallet_sudo/struct.GenesisConfig.html | Timeout

etc, there are more. I saw we have a link-check job already that uses lychee, perhaps it can be revisited. cc @paritytech/ci

@mrcnski
Copy link
Contributor Author

mrcnski commented Dec 18, 2023

nvm, closing in favor of #134.

@mrcnski mrcnski closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant