Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review all functions that accept Location and AssetId #3038

Open
KiChjang opened this issue Jan 24, 2024 · 2 comments
Open

Review all functions that accept Location and AssetId #3038

KiChjang opened this issue Jan 24, 2024 · 2 comments
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. T6-XCM This PR/Issue is related to XCM.

Comments

@KiChjang
Copy link
Contributor

#1230 made it so that all Location values are now non-Copy. We'll need to ensure that all the existing functions that require taking ownership of Location or AssetId don't actually require ownership, and in such cases, use a reference instead.

@KiChjang KiChjang added the T6-XCM This PR/Issue is related to XCM. label Jan 24, 2024
@MrishoLukamba
Copy link

MrishoLukamba commented Jan 31, 2024

Am taking it (PBA student)

But one thing, many helper functions take ownership of Location and AssetId, making them take a reference there will be much inconsistency in the code as some parameters could be
fn exmaple_fn( origin: Location, dest: & Location){}

And if changes so that every parameter to be a reference at the end of the day some u will clone them as Events and other traits require ownership ( such as Config traits associated types trait bounds)

@KiChjang

@acatangiu acatangiu added the C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. label Mar 28, 2024
@acatangiu acatangiu moved this from Draft to Backlog in Parity Roadmap Mar 28, 2024
@alexxxkny
Copy link

alexxxkny commented Oct 24, 2024

Please also note this Copy constraint that makes it impossible to use v4::Location with pallet_asset_tx_payment: https://github.com/paritytech/polkadot-sdk/blob/polkadot-stable2409/substrate/frame/transaction-payment/asset-tx-payment/src/payment.rs#L43

@bkontur bkontur moved this to Todo in Bridges + XCM Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. T6-XCM This PR/Issue is related to XCM.
Projects
Status: Todo
Status: Backlog
Development

No branches or pull requests

4 participants