Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XCM]: Remove NetworkIds for testnets #5241

Closed
acatangiu opened this issue Aug 5, 2024 · 3 comments · Fixed by #5390 or #4826
Closed

[XCM]: Remove NetworkIds for testnets #5241

acatangiu opened this issue Aug 5, 2024 · 3 comments · Fixed by #5390 or #4826

Comments

@acatangiu
Copy link
Contributor

Implement RFC polkadot-fellows/RFCs#108

@programskillforverification
Copy link
Contributor

So, it is specified only like Bygenesis("d4e56740f87....")?

@franciscoaguirre
Copy link
Contributor

So, it is specified only like Bygenesis("d4e56740f87....")?

Yes

@franciscoaguirre franciscoaguirre mentioned this issue Aug 16, 2024
10 tasks
@programskillforverification
Copy link
Contributor

I will work on this.

@franciscoaguirre franciscoaguirre moved this from Todo to In Progress in Bridges + XCM Oct 8, 2024
franciscoaguirre added a commit that referenced this issue Nov 1, 2024
# Context
Close #5241, for more detail, please refer to
[RFC0108](polkadot-fellows/RFCs#108)
# Changes
- Remove `Rococo` and `Westend` from `NetworkId`
* Add `Rococo Genesis Hash` and `Westend Genesis Hash`

---------

Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
github-merge-queue bot pushed a commit that referenced this issue Nov 6, 2024
# Context

This PR aims to introduce XCMv5, for now it's in progress and will be
updated over time.
This branch will serve as a milestone branch for merging in all features
we want to add to XCM, roughly outlined
[here](polkadot-fellows/xcm-format#60).
More features could be added.

## TODO
- [x] Migrate foreign assets from v3 to v4
- [x] Setup v5 skeleton
- [x] Remove XCMv2
- [x] #5390
- [x] #5585
- [x] #5420
- [x] #5876
- [x] #5971
- [x] #6148
- [x] #6228

Fixes #3434 
Fixes #4190
Fixes #5209
Fixes #5241
Fixes #4284

---------

Signed-off-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Andrii <ndk@parity.io>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Joseph Zhao <65984904+programskillforverification@users.noreply.github.com>
Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: command-bot <>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Serban Iorga <serban@parity.io>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Bridges + XCM Nov 6, 2024
x3c41a pushed a commit that referenced this issue Nov 21, 2024
# Context
Close #5241, for more detail, please refer to
[RFC0108](polkadot-fellows/RFCs#108)
# Changes
- Remove `Rococo` and `Westend` from `NetworkId`
* Add `Rococo Genesis Hash` and `Westend Genesis Hash`

---------

Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants