Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup script: Use the CI rust version of polkadot-sdk #5263

Open
kianenigma opened this issue Aug 6, 2024 · 2 comments · May be fixed by #5317
Open

Startup script: Use the CI rust version of polkadot-sdk #5263

kianenigma opened this issue Aug 6, 2024 · 2 comments · May be fixed by #5317
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.

Comments

@kianenigma
Copy link
Contributor

The getting started script introduced in #4879 is great, but it installs the latest rust verison by default, and this sometimes yields to warnings when compiling polkadot-sdk. It would be great to use the version that is expected to pass the CI.

This is visible in https://github.com/paritytech/polkadot-sdk/blob/master/.github/env, but perhaps it can be stored somewhere a bit more visible.

@kianenigma kianenigma added the D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. label Aug 6, 2024
@kianenigma kianenigma changed the title Startup script: Use the official rust version of polkadot-sdk Startup script: Use the CI rust version of polkadot-sdk Aug 6, 2024
@Wolfenheimm
Copy link

Hello @kianenigma - I've come up with a solution that fetches the version directly from the file using grep/cut. Please let me know if perhaps I misunderstood or if you would like more functionality :)

PR: #5317

@alvicsam
Copy link
Contributor

Another similar issue has been opened recently. We'll add rust-toolchain.toml with rust version as soon as we finish ci migration to github actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.
Projects
None yet
3 participants