Collective: dynamic deposit based on number of proposals

[muharem]

Introduce a dynamic proposal deposit mechanism influenced by the total number of active proposals, with the option to set the deposit to none.

The potential cost (e.g., balance hold) for proposal submission and storage is determined by the implementation of the Consideration trait. The footprint is defined as proposal_count, representing the total number of active proposals in the system, excluding the one currently being proposed. This cost may vary based on the proposal count. The pallet also offers various types to define a cost strategy based on the number of proposals.

Two new calls are introduced:

• kill(origin, proposal_hash): the cancellation of a proposal, accompanied by the burning of the associated cost/consideration ticket.
• release_proposal_cost(origin, proposal_hash): the release of the cost for a non-active proposal.

Additionally change:

• benchmarks have been upgraded to benchmarks::v2 for collective pallet;
• ensure_successful function added to the Consideration under runtime-benchmarks feature.

[muharem]

bot bench substrate-pallet --pallet=pallet_collective

[command-bot]

@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5126963 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_collective. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-c37ecb20-20d5-44d2-8d31-8d7682461de8 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@muharem Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_collective has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5126963 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5126963/artifacts/download.

[command-bot]

@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7206517 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_collective. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 38-7634b390-9a77-492a-bddd-4a66adf44289 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@muharem Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_collective has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7206517 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7206517/artifacts/download.

[mordamax]

/cmd bench --runtime dev --pallet pallet_collective

[github-actions]

Command "bench --runtime dev --pallet pallet_collective" has started 🚀 See logs here

[mordamax]

/cmd bench --runtime dev --pallet pallet_collective

[github-actions]

Command "bench --runtime dev --pallet pallet_collective" has started 🚀 See logs here

[github-actions]

Command "bench --runtime dev --pallet pallet_collective" has failed ❌! See logs here

[github-actions]

Command "bench --runtime dev --pallet pallet_collective" has failed ❌! See logs here

[muharem]

@mordamax there is no impl for () type. you can see it in this commit, the last /cmd removed it - e6b5891

[muharem]

@mordamax I run the bot to get this PR merged

[muharem]

bot bench substrate-pallet --pallet=pallet_collective

[command-bot]

@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7209062 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_collective. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 40-f28d3581-88d2-4a91-85c0-155643f03b83 to cancel this command or bot cancel to cancel all commands in this pull request.

[paritytech-cicd-pr]

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7208945

[command-bot]

@muharem Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_collective has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7209062 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7209062/artifacts/download.

[muharem]

bot bench substrate-pallet --pallet=pallet_collective

[command-bot]

@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7211356 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_collective. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-4da21e91-ec3f-4581-ab33-3e9f6f1ce500 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@muharem Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_collective has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7211356 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7211356/artifacts/download.

[mordamax]

@mordamax there is no impl for () type. you can see it in this commit, the last /cmd removed it - e6b5891

@ggwpez told me that it's perhaps of missing template for frame benches for /cmd, so I'll add shortly 🤝
Thanks !