From 77ad69d2573a39d80506c88752c7d3cc2d59261e Mon Sep 17 00:00:00 2001 From: Dom Date: Thu, 11 Apr 2024 20:01:33 -0400 Subject: [PATCH 1/7] Remove getter attribute from authority discovery --- substrate/frame/authority-discovery/src/lib.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/substrate/frame/authority-discovery/src/lib.rs b/substrate/frame/authority-discovery/src/lib.rs index ed9240d99e8d..16f71960d693 100644 --- a/substrate/frame/authority-discovery/src/lib.rs +++ b/substrate/frame/authority-discovery/src/lib.rs @@ -48,13 +48,11 @@ pub mod pallet { } #[pallet::storage] - #[pallet::getter(fn keys)] /// Keys of the current authority set. pub(super) type Keys = StorageValue<_, WeakBoundedVec, ValueQuery>; #[pallet::storage] - #[pallet::getter(fn next_keys)] /// Keys of the next authority set. pub(super) type NextKeys = StorageValue<_, WeakBoundedVec, ValueQuery>; From ca39da548376fe7542afa575d05c2b4f4cccdf5b Mon Sep 17 00:00:00 2001 From: Dom Date: Thu, 11 Apr 2024 20:58:37 -0400 Subject: [PATCH 2/7] Add prdoc --- prdoc/pr_4091.prdoc | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 prdoc/pr_4091.prdoc diff --git a/prdoc/pr_4091.prdoc b/prdoc/pr_4091.prdoc new file mode 100644 index 000000000000..8dd35a6a781c --- /dev/null +++ b/prdoc/pr_4091.prdoc @@ -0,0 +1,13 @@ +# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0 +# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json + +title: Remove `pallet::getter` usage from authority-discovery pallet + +doc: + - audience: Runtime Dev + description: | + This PR removes `pallet::getter` usage from `pallet-authority-discovery`. + The syntax `StorageItem::::get()` should be used instead. + +crates: + - name: pallet-authority-discovery From 99572f3b6d67364ca0a1f3de44fa811b05e998b2 Mon Sep 17 00:00:00 2001 From: Dom Date: Tue, 16 Apr 2024 09:18:57 -0400 Subject: [PATCH 3/7] Update pr_4091.prdoc --- prdoc/pr_4091.prdoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prdoc/pr_4091.prdoc b/prdoc/pr_4091.prdoc index 8dd35a6a781c..4bdc57311008 100644 --- a/prdoc/pr_4091.prdoc +++ b/prdoc/pr_4091.prdoc @@ -6,7 +6,7 @@ title: Remove `pallet::getter` usage from authority-discovery pallet doc: - audience: Runtime Dev description: | - This PR removes `pallet::getter` usage from `pallet-authority-discovery`. + This PR removes `pallet::getter`s from `pallet-authority-discovery`. The syntax `StorageItem::::get()` should be used instead. crates: From e29d3e801a5fff213cb60e6f4b14419740066baf Mon Sep 17 00:00:00 2001 From: Dom Date: Tue, 23 Apr 2024 12:27:00 -0400 Subject: [PATCH 4/7] Update pr_4091.prdoc --- prdoc/pr_4091.prdoc | 1 + 1 file changed, 1 insertion(+) diff --git a/prdoc/pr_4091.prdoc b/prdoc/pr_4091.prdoc index 4bdc57311008..d3384166782a 100644 --- a/prdoc/pr_4091.prdoc +++ b/prdoc/pr_4091.prdoc @@ -11,3 +11,4 @@ doc: crates: - name: pallet-authority-discovery + bump: minor \ No newline at end of file From 822c7d6e65c51e6769c1ad966f22081c36599229 Mon Sep 17 00:00:00 2001 From: Dom Date: Tue, 23 Apr 2024 12:30:48 -0400 Subject: [PATCH 5/7] Update pr_4091.prdoc --- prdoc/pr_4091.prdoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prdoc/pr_4091.prdoc b/prdoc/pr_4091.prdoc index d3384166782a..995d4e1ea981 100644 --- a/prdoc/pr_4091.prdoc +++ b/prdoc/pr_4091.prdoc @@ -11,4 +11,4 @@ doc: crates: - name: pallet-authority-discovery - bump: minor \ No newline at end of file + bump: minor From 932038d352b0a6b52ec0f22a94414619820adb7b Mon Sep 17 00:00:00 2001 From: "polka.dom" Date: Tue, 30 Apr 2024 16:19:21 -0400 Subject: [PATCH 6/7] Bump major Co-authored-by: Liam Aharon --- prdoc/pr_4091.prdoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prdoc/pr_4091.prdoc b/prdoc/pr_4091.prdoc index 995d4e1ea981..d9b2e07352a8 100644 --- a/prdoc/pr_4091.prdoc +++ b/prdoc/pr_4091.prdoc @@ -11,4 +11,4 @@ doc: crates: - name: pallet-authority-discovery - bump: minor + bump: major From 013f8df41a40fcc8d1c7d7b06de76478aed383ad Mon Sep 17 00:00:00 2001 From: "polka.dom" Date: Tue, 7 May 2024 21:13:54 -0400 Subject: [PATCH 7/7] Update pr_4091.prdoc --- prdoc/pr_4091.prdoc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/prdoc/pr_4091.prdoc b/prdoc/pr_4091.prdoc index d9b2e07352a8..5c38a344bd8a 100644 --- a/prdoc/pr_4091.prdoc +++ b/prdoc/pr_4091.prdoc @@ -1,13 +1,14 @@ # Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0 # See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json -title: Remove `pallet::getter` usage from authority-discovery pallet +title: Removed `pallet::getter` usage from the authority-discovery pallet doc: - audience: Runtime Dev description: | - This PR removes `pallet::getter`s from `pallet-authority-discovery`. - The syntax `StorageItem::::get()` should be used instead. + This PR removed `pallet::getter`s from `pallet-authority-discovery`s storage items. + When accessed inside the pallet, use the syntax `StorageItem::::get()`. + When accessed outside the pallet, use the getters current_authorities() and next_authorities() instead. crates: - name: pallet-authority-discovery