Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simple pool join & call to action UI #2050

Merged
merged 99 commits into from
Apr 2, 2024
Merged

Conversation

rossbulat
Copy link
Collaborator

@rossbulat rossbulat commented Apr 2, 2024

This PR introduces new UI for accounts that are not yet staking. The Status components of both nominate and pools pages have been refreshed to have larger call to action buttons with better syncing. A new canvas has been introduced for one-click pool joining, that randomly selects active and open pools for users to select.

TODO

  • Translations: @TingALin please can you translate. The new keys are already present in the cn locale files.

Breakdown of changes

  • Introduces a new canvas that automatically selects an active, open pool. Selectable pools are those that have been active for the last 14 eras. Users can click a "Choose Another Pool" to randomly select another eligible pool to join.
  • Improves initial app syncing by introducing default syncing values.
  • Introduces a new call to action component that displays large buttons. These are used as CTAs for nominating and pool joining / creation.
  • Fixes an issue where there was a race condition when fetching unclaimed pool rewards on account switching.
  • Fixes an issue where validator metrics buttons were being displayed in canvases.
  • Simplifies useSyncing hook by defaulting to wildcard.
  • Adds a Tx form factor for a large full-width submit button, accessed by a new DisplayFor property of card.
  • Improved abstraction of SubmitTx components.
  • Amends bond input components to only display the first error when there are multiple errors.
  • ClaimPermissionInput now requires a claim permission (no undefined value).
  • Unclaimed rewards and payout stats are now dimmed if the account is inactive.

Copy link
Collaborator Author

@rossbulat rossbulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review completed. translations & additional tests still to do.

@rossbulat rossbulat requested a review from TingALin April 2, 2024 09:24
@rossbulat rossbulat added the needs-translations Translations are needed to complete the PR label Apr 2, 2024
Ross Bulat and others added 2 commits April 2, 2024 16:29
@rossbulat rossbulat removed the needs-translations Translations are needed to complete the PR label Apr 2, 2024
@rossbulat rossbulat merged commit 6d04429 into main Apr 2, 2024
11 checks passed
@rossbulat rossbulat deleted the rb-simple-pool-join branch April 2, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants